Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/debug lodf #60

Merged
merged 56 commits into from
Oct 7, 2023
Merged

Jd/debug lodf #60

merged 56 commits into from
Oct 7, 2023

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Sep 28, 2023

Thanks for opening a PR to PowerNetworkMatrices.jl, please take note of the following when making a PR:

Check the contributor guidelines

i_count = 1
tmp = zeros(Float64, linecount, chunk_size)
while i_count <= linecount
edge = min(i_count + chunk_size - 1, linecount)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
edge = min(i_count + chunk_size - 1, linecount)
edge = min(i_count + chunk_size - 1, linecount)

src/lodf_calculations.jl Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

Performance Results

Version Precompile Time
Main 2.81350062
This Branch 2.431805152
Version Execute Time
Main-Build PTDF First 6.142113127
Main-Build PTDF Second 0.190156514
Main-Build Ybus First 0.437299731
Main-Build Ybus Second 0.010250209
Main-Build LODF First 0.817403258
Main-Build LODF Second 0.321716907
This Branch-Build PTDF First 4.775979033
This Branch-Build PTDF Second 0.186709803
This Branch-Build Ybus First 0.439598905
This Branch-Build Ybus Second 0.0097358
This Branch-Build LODF First 1.059281913
This Branch-Build LODF Second 0.316179204

src/lodf_calculations.jl Outdated Show resolved Hide resolved
src/ptdf_calculations.jl Outdated Show resolved Hide resolved
@jd-lara jd-lara marked this pull request as ready for review October 2, 2023 18:35
@jd-lara jd-lara self-assigned this Oct 2, 2023
@jd-lara jd-lara merged commit a13f879 into main Oct 7, 2023
8 of 9 checks passed
@jd-lara jd-lara deleted the jd/debug_LODF branch October 7, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant